refactor(v2): improve and unify theme config types

[armano2]

Motivation

i'v tried making this change minimal, and not touch to much of code, but going from any to proper type showed some errors

- key={isClient}
+ key={String(isClient)}

#4385 (comment)

Have you read the Contributing Guidelines on pull requests?

yes

[netlify]

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 366fbe6

https://deploy-preview-4433--docusaurus-2.netlify.app

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	100
🟠 Accessibility	72
🟢 Best practices	93
🟠 SEO	50
🟠 PWA	55

Lighthouse ran on https://deploy-preview-4433--docusaurus-2.netlify.app/

[netlify]

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit db2171d

https://deploy-preview-4433--docusaurus-2.netlify.app

[netlify]

[V1] Deploy preview failure

Built without sensitive environment variables with commit 366fbe6

https://app.netlify.com/sites/docusaurus-1/deploys/604df3349d18b600084d6bc9

[netlify]

[V1] Deploy preview failure

Built without sensitive environment variables with commit 6a353d8

https://app.netlify.com/sites/docusaurus-1/deploys/604df4eb881f23000797f673

[slorber]

Thanks for the cleanup :)

There's something that bothers: you moved all the theme types to @docusaurus/types but this type package is meant to be used for core types, not plugin/theme types, as these types are specific to one theme in particular, but some users might want to use Docusaurus with a totally different theme with different types. That's why {} is a valid/default type and the core ThemeConfig should remain Record<string,any> or something similar. Note it's possible to use Docusaurus with multiple themes at the same time, and we end up with a composition where the final theme config is the theme config of the 2 underlying themes (ClassicThemeConfig & LiveCodeBlockThemeConfig)

In practice, the plan is to share a common ThemeConfig type across multiple themes (classic/bootstrap/tailwind), but keep the core agnostic of those types, that's why the types were put in @docusaurus/theme-common

For now, it's not necessary to take any care of the bootstrap theme, it is not ready for usage at all.

[armano2]

ok, I'm going to update this with module augmentations

[netlify]

[V1] Deploy preview failure

Built without sensitive environment variables with commit 7532e80

https://app.netlify.com/sites/docusaurus-1/deploys/604edd5fa8fc4a000790fb35

[netlify]

[V1] Deploy preview failure

Built without sensitive environment variables with commit db2171d

https://app.netlify.com/sites/docusaurus-1/deploys/60548bd4733f1800088c5e7c

[Josh-Cena]

Closing because of how quickly things have evolved. A lot of things have already been addressed. Thanks @armano2 anyways :D