-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): fix grammar and improve wording #4481
Conversation
- resolve grammar issue in Setup heading and rephrase to (subjectively) more clear wording - more consistent wording in first line of Versioned paths heading
Hi @aehrea! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
[V1] Deploy preview failure Built without sensitive environment variables with commit e785a37 https://app.netlify.com/sites/docusaurus-1/deploys/60569edd8a1cd1000774e48d |
Let me know if there's anything against it but as I'd prefer to stay anonymous the CLA was signed with a pseudonym. |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit e785a37 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4481--docusaurus-2.netlify.app/ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
thanks :) |
Motivation
fix grammar issues and improve wording in https://v2.docusaurus.io/docs/docs-multi-instance
L50/55: grammar errors
L143: clarify each plugin instance ...; doing so also matches the wording used under "Tagging new versions" (L167)
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)