-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Add Qovery to deployment doc #4496
Conversation
Hi @arnaudjnn! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
[V1] Built with commit b17fb09 |
[V2] Built with commit b17fb09 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4496--docusaurus-2.netlify.app/ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Happy to add Qovery to the list of deployment options.
Can you make this more succinct? I'd rather have fewer instructions and a link to a more exhaustive tutorial hosted on Qovery website.
The current instructions do not look really good to me. If you want a step by step tutorial you'd better host that directly on Qovery and add screenshots. I'd rather limit the "click on" instructions
Also please add Qovery at the very end after QuantCDN as you added it after it is weird to add it in the middle of the doc.
I'll accept this PR if you remove the backported docs and the config file. FYI I think we are going to split the deployment options into multiple pages. |
We plan a website rebranding soon so we can't add this tutorial on our side for now. Let me know if I can improve the current PR according to your recommendation or if I should wait for our internal page. |
No that's fine, you'll edit the page when you'll have your new site Please just remove the alpha72 docs, no need to backport on any older version. |
@@ -1,399 +0,0 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should not be removed 😅 just the lines you added
Motivation
We want to offer to the community a quick and free way to deploy Docusaurus to production.
Have you read the [Contributing Guidelines on pull requests]
Yes