Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add social-embed to showcase #4568

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

tony
Copy link
Contributor

@tony tony commented Apr 3, 2021

Loving the project.

Motivation

Add https://social-embed.git-pull.com to the v2 showcase

Have you read the Contributing Guidelines on pull requests?

Yes, and the header of src/data/user.js

@tony tony requested review from lex111 and slorber as code owners April 3, 2021 19:49
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 3, 2021
@netlify
Copy link

netlify bot commented Apr 3, 2021

@github-actions
Copy link

github-actions bot commented Apr 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4568--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Apr 5, 2021

thanks ;)

@slorber slorber merged commit a627a26 into facebook:master Apr 5, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 5, 2021
@tony tony deleted the tn-showcase-social-embed branch April 5, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants