Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add appId into algoliaConfig #481

Merged
merged 2 commits into from
Mar 4, 2018

Conversation

atroncy
Copy link
Contributor

@atroncy atroncy commented Mar 1, 2018

Motivation

Allow user to add their own appId into algolia configuration.
See the issue 465

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

  • Do not change siteConfig.js
    • Run yarnpkg start from ../website
    • Make sure search work as before
  • Add appId into algolia config in siteConfig.js,
    • Run yarnpkg start from ../website
    • Make sure search work and effectively use given appId (note i it did my own set of apiKey/appId for this test)

Note i did also ran yarn jest and yarn prettier.

Related PRs

Not related to any pr.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 1, 2018
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me thanks!

@JoelMarcey
Copy link
Contributor

@atroncy Thank you! I will merge this.

I will add the documentation for the Algolia fields in another commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants