Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix Java syntax highlight in website #4849

Merged
merged 1 commit into from
May 25, 2021

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 25, 2021

Motivation

The Java syntax highlight is finally broken in docusaurus.io. (Weird I say finally here, but no-one had any idea why it worked before.) Now is good time to add java to additionalLanguages and make the site consistent with our documentation.

Broken highlight

Fix #4845.

Have you read the Contributing Guidelines on pull requests?

Yea

Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 25, 2021
@netlify
Copy link

netlify bot commented May 25, 2021

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 51
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4849--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title docs(v2): fix Java syntax highlight fix(v2): fix Java syntax highlight in website May 25, 2021
@lex111 lex111 merged commit 334cab3 into facebook:master May 25, 2021
@lex111
Copy link
Contributor

lex111 commented May 25, 2021

@Josh-Cena we probably didn't notice this as this is "just example of tabs", so it's good that you paid attention to this, thanks.

@lex111 lex111 changed the title fix(v2): fix Java syntax highlight in website docs(v2): fix Java syntax highlight in website May 25, 2021
@lex111 lex111 added documentation The issue is related to the documentation of Docusaurus pr: documentation This PR works on the website or other text documents in the repo. and removed documentation The issue is related to the documentation of Docusaurus labels May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java syntax highlighting doesn't work
3 participants