-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(v2): remove type attribute from link and script tags #4907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✔️ [V1] 🔨 Explore the source changes: a0e0d9b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60c0a89e5a932f000742345b 😎 Browse the preview: https://deploy-preview-4907--docusaurus-1.netlify.app |
✔️ [V2] 🔨 Explore the source changes: a0e0d9b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c0a89e21a9a50007d944d0 😎 Browse the preview: https://deploy-preview-4907--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4907--docusaurus-2.netlify.app/ |
Size Change: -897 B (0%) Total Size: 620 kB
ℹ️ View Unchanged
|
Motivation
These are completely unnecessary attributes that are actually already being removed by the minifier (terser), so we can remove them from the codebase itself.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)