-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): tidy up Markdown page layout #4917
Conversation
✔️ [V2] 🔨 Explore the source changes: 611e063 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60bcc4306baa95000727cbcb 😎 Browse the preview: https://deploy-preview-4917--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4917--docusaurus-2.netlify.app/ |
✔️ [V1] 🔨 Explore the source changes: 611e063 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60bcc43063e29f0007525a7f 😎 Browse the preview: https://deploy-preview-4917--docusaurus-1.netlify.app |
Size Change: +44 B (0%) Total Size: 621 kB
ℹ️ View Unchanged
|
2574391
to
611e063
Compare
I'm not a designer but find it better if the actual content remains centered. I don't like too much the idea of having the TOC move the content to the left. Also, wouldn't this lead to different md page layouts for pages with/without TOC? Is the content of a page without TOC moved to the left (would be weird)? or in this case, the content is in the center? I'd rather keep them all looking the same so that it's not confusing when you navigate from a page with TOC to a page without TOC (ie the content remains at the same place) |
Hmmm isn't it the same screenshot? Can't tell the differences. @yangshun any opinion regarding how the content should be centered? |
I wanted to show that if TOC is hidden, then the content column is stretched to container full width. |
Motivation
Quite strange looking now markdown page, I suppose it should be aligned to center like on all the other pages (see screenshots below).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(https://docusaurus.io/examples/markdownPageExample)
(https://deploy-preview-4917--docusaurus-2.netlify.app/examples/markdownPageExample)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)