Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: disable google-gtag plugin in Netlify deploys #4951

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 11, 2021

Motivation

At the moment we see that the performance in new Lighthouse reports has decreased. This is because Netlify now automatically include their own widget (Netlify Drawer) into preview sites. They promise to make it configurable, so for now I suggest disable the Google metrics from preview sites to slightly increase the current performance metrics.

image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Make sure that the preview is not using Google Analytics.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jun 11, 2021
@lex111 lex111 requested a review from slorber as a code owner June 11, 2021 09:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 11, 2021
@netlify
Copy link

netlify bot commented Jun 11, 2021

✔️ [V2]

🔨 Explore the source changes: ff450c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c32c398d941d00073950c9

😎 Browse the preview: https://deploy-preview-4951--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4951--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 621 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.8 kB 0 B
website/build/assets/js/main.********.js 444 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 14, 2021

👍 why not

@slorber slorber merged commit 4e5f0fe into master Jun 14, 2021
@slorber slorber deleted the lex111/disable-gtag-ci branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants