-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(v2): reduce top padding in doc content container #4995
Conversation
@@ -19,10 +19,6 @@ | |||
width: 100%; | |||
} | |||
|
|||
.docItemWrapper { | |||
padding-top: 0.5rem !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now top padding will be slightly larger instead of 0.5 -> 1rem, but it's still good.
✔️ [V2] 🔨 Explore the source changes: 04c4442 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60cb1fedd0a9040007650059 😎 Browse the preview: https://deploy-preview-4995--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4995--docusaurus-2.netlify.app/ |
Size Change: -21 B (0%) Total Size: 624 kB ℹ️ View Unchanged
|
👍 |
I feel this Removing this |
thanks @CovalentBond , will fix this in #5035 |
Motivation
Re-attempted to apply the changes from #4877.
Because of style minification the changes from that PR didn't apply (didn't notice it right away). So I decided to use the built-in Infima utility classes to achieve purpose of that PR.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)