Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): reduce top padding in doc content container #4995

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 17, 2021

Motivation

Re-attempted to apply the changes from #4877.

Because of style minification the changes from that PR didn't apply (didn't notice it right away). So I decided to use the built-in Infima utility classes to achieve purpose of that PR.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jun 17, 2021
@lex111 lex111 requested a review from slorber as a code owner June 17, 2021 10:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 17, 2021
@@ -19,10 +19,6 @@
width: 100%;
}

.docItemWrapper {
padding-top: 0.5rem !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now top padding will be slightly larger instead of 0.5 -> 1rem, but it's still good.

@netlify
Copy link

netlify bot commented Jun 17, 2021

✔️ [V2]

🔨 Explore the source changes: 04c4442

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60cb1fedd0a9040007650059

😎 Browse the preview: https://deploy-preview-4995--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4995--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -21 B (0%)

Total Size: 624 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.6 kB -21 B (0%)
website/build/assets/js/main.********.js 445 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 63.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 28.1 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 18, 2021

👍

@slorber slorber merged commit 0e65273 into master Jun 18, 2021
@idontknowjs
Copy link
Contributor

@slorber @lex111

I feel this max-width for smaller viewports added can be removed the DocPage here. This is causing the text in TOC to be wrapped to the next line and main content to shrink. I would like to submit the PR!

image

Removing this docItemWrapper class probably makes the layout look better as shown below!

image

@slorber
Copy link
Collaborator

slorber commented Jun 22, 2021

thanks @CovalentBond , will fix this in #5035

@slorber slorber deleted the lex111/pr4877 branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants