feat(v2): plugins injectHtmlTags + configureWebpack should receive content loaded #5037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Plugin lifecycles that are triggered after we loaded the plugin content should permit to access that plugin content.
The following should work:
Also injecting the content in the
configureWebpack
lifecycle, as we compute the mdx/remark config by using the loaded content for resolving relative file path links to URLs. This permits to avoid an unelegant side-effect we previously had inloadContent
:Mentioned in #4923 (comment)
Test Plan
test + dogfood in internal plugins