Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): update installation docs #5073

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Conversation

iamayushdas
Copy link
Contributor

@iamayushdas iamayushdas commented Jun 27, 2021

Motivation

I was upgrading the docusaurus and saw that new release has been done, and i checked the installation is not updated

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 27, 2021
@netlify
Copy link

netlify bot commented Jun 27, 2021

✔️ [V2]

🔨 Explore the source changes: 54b2213

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60da0e09271b6d0008a65b78

😎 Browse the preview: https://deploy-preview-5073--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 27, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5073--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

In fact the website is not incorrect:

Please update to the latest Docusaurus 2 version shown at the top of the page, not what is shown below.

The version here is only an example.

@iamayushdas
Copy link
Contributor Author

In fact the website is not incorrect:

Please update to the latest Docusaurus 2 version shown at the top of the page, not what is shown below.

The version here is only an example.

yes, I triggered a problem while updating from 2.0.0beta.0 to 2.0.0beta.2 , documentations not loading at all

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Unfortunately we can't keep updating the docs on each release, we need a better solution to solve this (like using MDX)

website/docs/installation.md Outdated Show resolved Hide resolved
website/docs/installation.md Outdated Show resolved Hide resolved
@slorber slorber changed the title docs: update installation docs to 2.0.0beta.2 docs(v2): update installation docs Jun 28, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 28, 2021
@iamayushdas iamayushdas requested a review from slorber June 29, 2021 00:48
@slorber slorber merged commit 632b21b into facebook:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants