Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): revert webpack.resolve.symlinks = false #5164

Merged
merged 3 commits into from
Jul 13, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 13, 2021

Motivation

Revert change made in #5126 => back to webpack.resolve.symlinks = true

We can't do this change because there's a bug in Webpack 5 cache when resolve.symlinks = false.
Disabling the cache is really painful for the development experience.

More infos reported here:

Also adding correct dev watchOptions so that it would work if we decide later to change to resolve.symlinks = false again, or if the user does this with custom Webpack config.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

Related PRs

#5126

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 13, 2021
@slorber slorber requested a review from lex111 as a code owner July 13, 2021 18:00
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 13, 2021
@netlify
Copy link

netlify bot commented Jul 13, 2021

✔️ [V2]

🔨 Explore the source changes: 772c506

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60edd4ca3fb123000730b7f9

😎 Browse the preview: https://deploy-preview-5164--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5164--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +31 B (0%)

Total Size: 973 kB

Filename Size Change
website/build/assets/js/main.********.js 458 kB +31 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 58.8 kB
website/build/assets/css/styles.********.css 89 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.3 kB
website/build/blog/index.html 26.3 kB
website/build/docs-tests/index.html 132 kB
website/build/docs-tests/standalone/index.html 19.1 kB
website/build/docs/index.html 46.4 kB
website/build/docs/installation/index.html 53.7 kB
website/build/index.html 27.3 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants