Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make proper highlighting doc link if no sidebar #5317

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix: make proper highlighting doc link if no sidebar #5317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f129cf8
fix: All navbar items without sidebar are active
hamzahamidi Aug 7, 2021
c113b0c
Update packages/docusaurus-theme-classic/src/theme/NavbarItem/DocNavb…
hamzahamidi Aug 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/src/theme/NavbarItem/DocNavbarItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function DocNavbarItem({
{...props}
className={clsx(props.className, {
[activeDocInfimaClassName]:
activeDoc && activeDoc.sidebar === doc.sidebar,
activeDoc?.sidebar && activeDoc.sidebar === doc.sidebar,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case navbar items without sidebar always will be inactive?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it would work fine because it's already the default behavior for a link to be active when we are on the link target page. We only need this additional class to enable the "tab-like" behavior.

})}
activeClassName={activeDocInfimaClassName}
label={staticLabel ?? doc.id}
Expand Down