-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unbreak Details component #5364
Conversation
✔️ [V2] 🔨 Explore the source changes: 253065a 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6119603cd5e62d0008e53d4e 😎 Browse the preview: https://deploy-preview-5364--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5364--docusaurus-2.netlify.app/ |
@Josh-Cena this isn't the first time something is broken after your refactoring and I have to fix it, so please check your changes carefully, we don't have dedicated QA to check all incoming PRs, so it's very easy to break things! |
Size Change: -56 B (0%) Total Size: 803 kB
ℹ️ View Unchanged
|
Oops, didn't catch that, my bad 😅 Thanks for fixing, I will watch out more carefully next time After some thinking I think the a11y is wrong in warning that Edit. After some search I found out that actually |
Not all warnings reported by ESLint need actually be fixed. In my opinion, current implementation of |
Thanks My fault, I should have tested better the other PR, didn't think it would break anything |
Motivation
After merge #5341 our custom component for
details
element no longer work correctly, so this PR rolls back changes made in that PR.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Current state (https://docusaurus.io/docs/markdown-features#details):
Expected one - fixed (https://deploy-preview-5364--docusaurus-2.netlify.app/docs/markdown-features#details):
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)