Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add Nocalhost website to showcase page #5369

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

neaped
Copy link
Contributor

@neaped neaped commented Aug 16, 2021

Motivation

nocalhost.dev using Docusaurus V2 for website and blog

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Test in http://localhost:3000/showcase to make sure everything is up and running correctly.

@neaped neaped requested review from lex111 and slorber as code owners August 16, 2021 13:40
@facebook-github-bot
Copy link
Contributor

Hi @neaped!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ [V2]

🔨 Explore the source changes: d44b298

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611b8842bdb1470008403b4f

😎 Browse the preview: https://deploy-preview-5369--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 16, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5369--docusaurus-2.netlify.app/

@neaped neaped closed this Aug 16, 2021
@neaped neaped reopened this Aug 16, 2021
@neaped
Copy link
Contributor Author

neaped commented Aug 16, 2021

CLA has signed, should I resubmit the request or just wait for the tools?

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 16, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

website/src/data/users.tsx Outdated Show resolved Hide resolved
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 17, 2021
@slorber slorber merged commit 09a9541 into facebook:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants