-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix Locale Dropdown RTL icon + Webpack aliases ordering #5383
Conversation
@slorber the English word is not aligned with that character. Please check docusaurus website to see the diff. |
✔️ [V2] 🔨 Explore the source changes: de00328 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611e64f346dcb80007e7404e 😎 Browse the preview: https://deploy-preview-5383--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5383--docusaurus-2.netlify.app/ |
Size Change: -1 B (0%) Total Size: 810 kB ℹ️ View Unchanged
|
@massoudmaboudi I can't fix your issue in a generic way because it's due to your Nunito font. Afaik there's no good generic way to align properly an SVG and some text that works for all fonts, but if you know one PRs are welcome. |
@slorber |
Motivation
Fix for #5382
I was lazy and used inline styles, but the postCSS RTL plugin are not applied to inline styles so we should avoid them.
Also fixing an edge case found in Webpack alias ordering when an intermediate folder has an index.js file
@theme/NavbarItem
should always be AFTER@theme/NavbarItem/LocaleDropdownNavbarItem
or it would shadow it.