Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some beta.5 bugfixes #5431

Merged
merged 1 commit into from
Aug 27, 2021
Merged

fix: some beta.5 bugfixes #5431

merged 1 commit into from
Aug 27, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 27, 2021

Motivation

  • Bad CSS class applied to active dropdown links.
- dropdown__link navbar__link--active
+ dropdown__link dropdown__link--active

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 27, 2021
@slorber slorber requested a review from lex111 as a code owner August 27, 2021 10:48
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 27, 2021
@netlify
Copy link

netlify bot commented Aug 27, 2021

✔️ [V2]

🔨 Explore the source changes: e8ad95d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6128c2e470762b0007119b6a

😎 Browse the preview: https://deploy-preview-5431--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5431--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -248 B (0%)

Total Size: 820 kB

Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.6 kB -36 B (0%)
website/build/blog/index.html 37.4 kB -36 B (0%)
website/build/docs/index.html 44 kB -34 B (0%)
website/build/docs/installation/index.html 52 kB -34 B (0%)
website/build/index.html 30.2 kB -36 B (0%)
website/build/tests/docs/index.html 24.5 kB -36 B (0%)
website/build/tests/docs/standalone/index.html 22.3 kB -36 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 36.5 kB
website/build/assets/css/styles.********.css 95 kB
website/build/assets/js/main.********.js 411 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants