fix: fix a few TS errors

[Josh-Cena]

Motivation

The TypeScript compiler screams at me again after bumping to beta.5 when I ran tsc in my site repo. It turns out that CI checks fall short when it comes to the .d.ts files, so these mistakes tend to sneak in unnoticed.

Have you read the Contributing Guidelines on pull requests?

Yes

Test plan

cd website && yarn typecheck

This actually works well. Should we add it to the CI?

[netlify]

✔️ [V2]

🔨 Explore the source changes: 1aa2cc5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/612cb7fda8e187000787f5a4

😎 Browse the preview: https://deploy-preview-5437--docusaurus-2.netlify.app

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	86
🟢 Accessibility	98
🟢 Best practices	100
🟢 SEO	100
🟢 PWA	95

Lighthouse ran on https://deploy-preview-5437--docusaurus-2.netlify.app/

[Josh-Cena]

Okay this is annoying😅 As the website is also built into a PWA, it uses the workbox library which requires setting TS compiler to lib: ["webworker"], but "webworker" and "DOM" are incompatible. Therefore running typecheck in website is sure to fail. Not sure what we should do

Also, the new tsconfig still doesn't do its magic on resolving @site/ aliases

[slorber]

Okay this is annoying😅 As the website is also built into a PWA, it uses the workbox library which requires setting TS compiler to lib: ["webworker"], but "webworker" and "DOM" are incompatible. Therefore running typecheck in website is sure to fail. Not sure what we should do

This seems to fix it:

• "exclude": ["src/sw.js"]
• Also skipLibChecks: true but the 1st is better. I don't think it's too important to type-check this file 🤪

Also, the new tsconfig still doesn't do its magic on resolving @site/ aliases

Weird 🤪 I can't make it work either

I guess it's fine to merge this for now and figure out why the site alias can't be in parent config

[slorber]

Added yarn workspace website tsc to our test workflow, it should help catch those d.ts issues

We'll figure out the @site alias in another PR

Thanks 👍

[Josh-Cena]

Okay as long as tsc passes I'm fine 😏