Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation link issue #591

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Fix documentation link issue #591

merged 1 commit into from
Apr 23, 2018

Conversation

shikaan
Copy link
Contributor

@shikaan shikaan commented Apr 23, 2018

Motivation

There was two times the same link, none of which was pointing to the correct npm package.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Click on the link and see that the correct npm package is shown

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 23, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun merged commit 7b674c1 into facebook:master Apr 23, 2018
@yangshun
Copy link
Contributor

Many thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants