Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect version links #598

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Fix incorrect version links #598

merged 2 commits into from
Apr 24, 2018

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Apr 24, 2018 •
edited
Loading

Motivation

  • The releases page was incorrectly pointing to Relay's releases page.
  • Add missing key to render.
  • General formatting improvements.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Load versions page locally and clicked around.

Related PRs

NA

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 24, 2018
JoelMarcey
JoelMarcey approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks.

@JoelMarcey
Copy link
Contributor

We might want to make similar fixes to the example versions file too. https://github.com/facebook/Docusaurus/blob/master/examples/versions/pages/en/versions.js

@JoelMarcey JoelMarcey merged commit 5404874 into facebook:master Apr 24, 2018
@yangshun yangshun deleted the fix-version-error branch April 25, 2018 05:14
@NikolayS NikolayS mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelMarcey JoelMarcey JoelMarcey approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangshun @JoelMarcey @facebook-github-bot