Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve <table> appearance #607

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Improve <table> appearance #607

merged 1 commit into from
Apr 26, 2018

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Apr 26, 2018 •
edited
Loading

Motivation

Fix #356. General changes made:

  • Don't uppercase heading cells. This is usually unwanted and should not be a default.
  • Switch the stripe background to be on even cells to prevent tables with one row from appearing just gray.
  • Make the stripe background color a bit lighter. It was a little too dark.
  • Remove some of the unnecessary CSS and selector nesting.

In general, these changes should be an improvement for existing users unless they have heavily customized the table styling, then it might conflict.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Before

screen shot 2018-04-25 at 11 02 32 pm

After

screen shot 2018-04-25 at 11 02 40 pm

Related PRs

NA.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 26, 2018
JoelMarcey
JoelMarcey approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 Thanks for the design work!

@JoelMarcey JoelMarcey merged commit 3a24606 into facebook:master Apr 26, 2018
@yangshun yangshun deleted the tables-css branch April 27, 2018 21:11
@snyk-bot snyk-bot mentioned this pull request May 25, 2021
Open
@Qdigital Qdigital mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelMarcey JoelMarcey JoelMarcey approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangshun @JoelMarcey @facebook-github-bot