Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-docs): getMainDocId should return doc with both versioned or unversioned id #6085

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 10, 2021

Motivation

Little retro compatibility issue after updating the sidebar versioning strategy (see also #6018)

Affecting the Jest website, which is not using slug: / unlike our website, so we didn't see this issue on our own website

image

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

local only, it's code that we'll remove quite soon anyway (as part of #6018)

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 10, 2021
@netlify
Copy link

netlify bot commented Dec 10, 2021

✔️ [V2]

🔨 Explore the source changes: cd97e31

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b380f53567890007b4e1d3

😎 Browse the preview: https://deploy-preview-6085--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6085--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 37.8 kB
website/build/assets/css/styles.********.css 101 kB
website/build/assets/js/main.********.js 484 kB
website/build/index.html 29.3 kB

compressed-size-action

@JoelMarcey JoelMarcey merged commit fd2934d into main Dec 10, 2021
@JoelMarcey JoelMarcey deleted the slorber/fix-sidebar-mainDocId-issue branch December 10, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants