Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme-classic): new configuration syntax for a simple footer #6132
feat(theme-classic): new configuration syntax for a simple footer #6132
Changes from 5 commits
7360ad2
01d0e18
350e9b3
1d7192f
3c91aeb
d73eb97
71d595d
a4ab06f
854ee6f
4f05fc8
f580748
e282340
cf55c1a
e28c22e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config validation allows undefined/null.
Undefined can lead to type guards thinking it's a simple footer despite being a multi column one:
null can lead to a weird rendering alignment:
Not sure who's using null, it may make sense to disable column titles and the alignment may be good enough if none of the columns have titles...
Edit: see use-case for null: #4267
Just adding
default(null)
to title validation + this type might be good enough.