Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-docs): quotify path when retrieving git history #6202

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

A really small bug, didn't trick us because we don't have spaces in our path.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Unit test
  2. Enabled last update in dogfooding plugin which has a folder with space

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Dec 27, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 27, 2021
@netlify
Copy link

netlify bot commented Dec 27, 2021

✔️ [V2]

🔨 Explore the source changes: dad5eac

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61c982e40f8e080008da127f

😎 Browse the preview: https://deploy-preview-6202--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6202--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit 3195e7f into main Dec 27, 2021
@Josh-Cena Josh-Cena deleted the jc/fix-last-update branch December 27, 2021 09:27
@github-actions
Copy link

Size Change: +22 B (0%)

Total Size: 662 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 40.1 kB 0 B
website/build/assets/css/styles.********.css 102 kB 0 B
website/build/assets/js/main.********.js 490 kB +22 B (0%)
website/build/index.html 29.6 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants