refactor(theme-classic): extract common PaginatorNavLink component #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 28e1931 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61cbdb0beea2d30007f204b5 😎 Browse the preview: https://deploy-preview-6213--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6213--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 667 kB ℹ️ View Unchanged
|
slorber
approved these changes
Dec 29, 2021
| import Link from '@docusaurus/Link'; | ||
| import type {Props} from '@theme/PaginatorNavLink'; | ||
|
|
||
| function PaginatorNavLink(props: Props): JSX.Element { |
There was a problem hiding this comment.
not a big deal for now, but this is bad encapsulation that Infima is using a --next suffix in parent class to determine the position/direction of the arrow. This should be a props instead of a parent class, and this component should be self-sufficient to render properly without using any parent CSS
slorber
added
pr: bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #6171.
PaginatorNavLinkcomponent.Have you read the Contributing Guidelines on pull requests?
Yes