Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dyte docs to showcase #6274

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

vaibhavshn
Copy link
Contributor

Motivation

Adding our docs to your showcase!

Have you read the Contributing Guidelines on pull requests?

YES

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

NONE

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

NONE

@facebook-github-bot
Copy link
Contributor

Hi @vaibhavshn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Jan 6, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 0b539e0

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61d6d1f4e727c900087cb314

😎 Browse the preview: https://deploy-preview-6274--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6274--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 6, 2022
@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Jan 6, 2022

Thanks! Very nice site. Just waiting for the CLA check... It's a shame that we can't see the source though

@vaibhavshn
Copy link
Contributor Author

Thanks! Very nice site. Just waiting for the CLA check... It's a shame that we can't see the source though

Thanks! Signing the Employer CLA in a while, might take some time. Will update as soon as I do it.

We are planning on open sourcing it in the future though.

@Josh-Cena
Copy link
Collaborator

That's great to hear! Please remember to update the showcase data once you open-sourced your site. It would be an inspiration for other users 😉

@vaibhavshn
Copy link
Contributor Author

That's great to hear! Please remember to update the showcase data once you open-sourced your site. It would be an inspiration for other users 😉

Definitely!

@slorber
Copy link
Collaborator

slorber commented Jan 6, 2022

❤️ great site

Please report customization use-cases here so that we can allow you to make those customizations in a more robust way:
#5468

@vaibhavshn
Copy link
Contributor Author

The CLA has been signed.

@vaibhavshn
Copy link
Contributor Author

❤️ great site

Please report customization use-cases here so that we can allow you to make those customizations in a more robust way: #5468

Thanks!
Will collect points and post it in the discussion.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 6, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@slorber
Copy link
Collaborator

slorber commented Jan 6, 2022

Thanks ;)

@slorber slorber merged commit e231359 into facebook:main Jan 6, 2022
@vaibhavshn vaibhavshn deleted the feat/showcase-dyte branch January 6, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants