Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Dependabot for dependency updates #6325

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

nschonni
Copy link
Contributor

Motivation

As discussed in #3552
Maybe you want to go with Renovate Bot in the longer term, but at least this would get something going.
Kept updates to weekly to reduce some of the noise, but maybe you want to increase it to monthly and just use the manual trigger on the Insights tab to trigger manually

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Jan 13, 2022

This doesn't need configuration from the admin, yeah? I haven't used Dependabot since around the time it was integrated into GH.

Also, we can go even less frequently than that (e.g. biweekly). I would investigate the actual configuration.

@nschonni
Copy link
Contributor Author

Monthly is the max right now https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#scheduleinterval
I'd probably let the GitHub Actions one stay more frequent, since most of the actions are just pointing to the major versions anyway

@nschonni
Copy link
Contributor Author

I don't believe any admin setup is required with the config file now, but it was in the past when it was done through the separate app

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 37a1a14

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61dfce0cc8fb610008b4cedb

😎 Browse the preview: https://deploy-preview-6325--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 13, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6325--docusaurus-2.netlify.app/

.github/dependabot.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I don't like Dependabot and I use Renovate for my projects, because Dependabot has no batch-updates and ends up sending 3 PRs to upgrade one monorepo (e.g. ts-eslint) which creates huge noise in our history. It also usually means waiting for Dependabot to resolve conflicts after merging every PR. But... seems we haven't progressed much with integrating Renovate.

I would leave the decision to @slorber

Co-authored-by: Nick Schonning <nschonni@gmail.com>
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 13, 2022
@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 13, 2022
@Josh-Cena
Copy link
Collaborator

@nschonni Is there a way for us to ignore certain lockfiles and only update the one at the root? I noticed that dependabot opens four PRs at a time because we have three example packages that aren't supposed to be modified

@nschonni
Copy link
Contributor Author

This one is only pointing to the root package/yarn.lock right now. To pick up nested ones, that would be separate entries in the config (like for the examples if you decided you wanted it later)

@Josh-Cena
Copy link
Collaborator

Oh, I see. That sounds good

@slorber
Copy link
Collaborator

slorber commented Jan 14, 2022

Until we set up Renovate, that seems reasonable to use this bot for now as I don't need to ask Joel to set up anything.

Will we get flooded with a lot of immediate PRs just after the merge?

@Josh-Cena
Copy link
Collaborator

Will we get flooded with a lot of immediate PRs just after the merge?

We probably will, considering the size of our yarn.lock... Let's do a manual relock first, shall we?

@slorber
Copy link
Collaborator

slorber commented Jan 14, 2022

Yes, I'm doing one right now

@Josh-Cena
Copy link
Collaborator

Did one myself as well, noticed a few type incompatibilities, probably the @types/ files were updated

@slorber
Copy link
Collaborator

slorber commented Jan 14, 2022

👍 let's give it a try

@slorber slorber merged commit b19bafd into facebook:main Jan 14, 2022
@Josh-Cena
Copy link
Collaborator

Oh, forgot to configure the Dependabot PR labels :D

@Josh-Cena
Copy link
Collaborator

No, actually, we don't want Dependabot to add labels: that's too much noise in our changelog. The default ones are fine

@nschonni nschonni deleted the dependabot branch January 14, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants