-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search): enable contextual search by default #6407
Conversation
✔️ [V2] 🔨 Explore the source changes: 2299bcb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61e8436bcc022f000891f04e 😎 Browse the preview: https://deploy-preview-6407--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6407--docusaurus-2.netlify.app/ |
Size Change: 0 B Total Size: 680 kB ℹ️ View Unchanged
|
from my testing, our site's search kinda broke after the update (not displaying anything when searching), so we had to set |
You may have a bad/outdated index crawling config, and it only works without contextual search. If you want versioning/i18n later, you'd rather update that config |
i literally had updated that config to what the example at Docusaurus v2 template showed ~15 days ago (because of the algolia migration, where the old config (automatic config) didnt work anymore), so i dont think i am using a too much outdated config (also, i dont modify that config myself, because i dont really understand all the options and the default work fine) |
@hasezoey then there might be another unexpected problem. If you deploy your site on a preview branch with contextual search enabled, we could inspect it more easily and see what is wrong |
deploy as in visitable from the web or deployed as in commits? when its commits, i have it still have the old commits Commits:
(can also be reproduced from local deployment, when contextual search is disabled, local search works, if enabled it does not) |
Breaking changes
contextualSearch: false
to revert to previous behaviorMotivation
Contextual Search has been widely used and makes sense for most sites
We can now safely turn this on by default (it has always been the long-term goal).
Fixes issues reported on versioned and i18n sites not enabling it. For example #5880
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
dogfood