Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation collapse on IE11 #641

Merged
merged 5 commits into from
May 6, 2018
Merged

Fix navigation collapse on IE11 #641

merged 5 commits into from
May 6, 2018

Conversation

ahmadalfy
Copy link
Contributor

@ahmadalfy ahmadalfy commented May 6, 2018

Motivation

Cross browser compatibility sets good example in open source projects. There are few issues happening in Internet Explorer 11 that blocks the usage of the website for its users.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

This PR will mostly be about UI changes that would affect CSS only. Plans for testing would be testing the UI on IE11 and another major browser (like Chrome) to ensure the updates doesn't break the new browsers as well as testing on mobile device.

Related issues

#585

ahmadalfy and others added 4 commits May 6, 2018 01:17
Implemented the solution provided [here](https://philipwalton.github.io/solved-by-flexbox/demos/sticky-footer/) to allow the footer to stick downward no matter how much content the page contain.
Implement sticky footer using flexbox
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 6, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 6, 2018

Deploy preview for docusaurus-preview ready!

Built with commit be75fa0

https://deploy-preview-641--docusaurus-preview.netlify.com

@ahmadalfy
Copy link
Contributor Author

Before:

image

After:
image

The reason:

flex: 1 on IE11 automatically set the flex-basis value to 0 without units on IE11. This leads to the collapse of the element and disallowing it from expanding and taking the size it should. This is a known issue on IE11 and usually countered by using flex: 1 1 auto in order to prevent that behavior

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Test it on Chrome and it works the same.

@ahmadalfy
Copy link
Contributor Author

My bad @yangshun

Should I remove the project and fork it again to avoid having the other PR commits on this one as well?

@yangshun
Copy link
Contributor

yangshun commented May 6, 2018

@ahmadalfy From your screenshots, the font looks bad. The screenshot in #585 doesn't look that bad. We want to use the system font if possible. Could you help to look into it and fix it if possible? Ideally we want to emulate GitHub, which also uses system fonts.

@yangshun
Copy link
Contributor

yangshun commented May 6, 2018

@ahmadalfy It's fine, I rebased it for you and it's ok now. You'll have to branch off latest master for your new PRs or rebase on master in future.

@ahmadalfy
Copy link
Contributor Author

Yes I already fixed that and it is coming on the next commit ;)

@yangshun yangshun merged commit 6d77403 into facebook:master May 6, 2018
@yangshun
Copy link
Contributor

yangshun commented May 6, 2018

Please title your PRs according to the specific fix you are making 😄

@yangshun yangshun changed the title [WIP] Fixes for Internet Explorer 11 Fix navigation collapse on IE11 May 6, 2018
@zenflow
Copy link
Contributor

zenflow commented May 6, 2018

Great work @ahmadalfy .. much appreciated!

@ahmadalfy
Copy link
Contributor Author

ahmadalfy commented May 6, 2018

@zenflow most welcomed ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants