-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation collapse on IE11 #641
Conversation
Implemented the solution provided [here](https://philipwalton.github.io/solved-by-flexbox/demos/sticky-footer/) to allow the footer to stick downward no matter how much content the page contain.
Implement sticky footer using flexbox
Deploy preview for docusaurus-preview ready! Built with commit be75fa0 |
Before: The reason:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Test it on Chrome and it works the same.
My bad @yangshun Should I remove the project and fork it again to avoid having the other PR commits on this one as well? |
@ahmadalfy From your screenshots, the font looks bad. The screenshot in #585 doesn't look that bad. We want to use the system font if possible. Could you help to look into it and fix it if possible? Ideally we want to emulate GitHub, which also uses system fonts. |
@ahmadalfy It's fine, I rebased it for you and it's ok now. You'll have to branch off latest master for your new PRs or rebase on master in future. |
Yes I already fixed that and it is coming on the next commit ;) |
Please title your PRs according to the specific fix you are making 😄 |
Great work @ahmadalfy .. much appreciated! |
@zenflow most welcomed ❤️ |
Motivation
Cross browser compatibility sets good example in open source projects. There are few issues happening in Internet Explorer 11 that blocks the usage of the website for its users.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
This PR will mostly be about UI changes that would affect CSS only. Plans for testing would be testing the UI on IE11 and another major browser (like Chrome) to ensure the updates doesn't break the new browsers as well as testing on mobile device.
Related issues
#585