Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(migrate): change internal methods' parameter style #6609

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Complete a TODO

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Unit test

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 5, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 5, 2022
@netlify
Copy link

netlify bot commented Feb 5, 2022

✔️ [V2]

🔨 Explore the source changes: a68bd34

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fdfb37498aac00075ff41b

😎 Browse the preview: https://deploy-preview-6609--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6609--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

Size Change: 0 B

Total Size: 771 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 47.2 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 582 kB
website/build/index.html 36.7 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants