refactor: remove deprecated Webpack utils & validation escape hatch #6740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: breaking change
|
✔️ [V2] 🔨 Explore the source changes: 3e3c020 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6214739f979f4400085a2221 😎 Browse the preview: https://deploy-preview-6740--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6740--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 781 kB ℹ️ View Unchanged
|
Josh-Cena
added
the
status: awaiting review
|
Agree 👍 LGTM thanks |
Josh-Cena
removed
the
status: awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The webpack loaders don't do anything, and no-one has complained so far, so let's remove them.
The validation system is quite stable now (although we did have a few mistakes, but those are inevitable), so we can remove that long hint message and the escape hatch (since it isn't documented anyways)
Have you read the Contributing Guidelines on pull requests?
Yes