Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow blog authors email #6783

Merged
merged 2 commits into from
Mar 2, 2022
Merged

feat: allow blog authors email #6783

merged 2 commits into from
Mar 2, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Currently, the authors don't appear in the RSS feed because they lack email. We can simply allow email in the metadata.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Updated test case

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Feb 28, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 28, 2022
@netlify
Copy link

netlify bot commented Feb 28, 2022

✔️ [V2]

🔨 Explore the source changes: 157408a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621c7e5e6eff890007b2e7dd

😎 Browse the preview: https://deploy-preview-6783--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 41
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6783--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

Size Change: 0 B

Total Size: 789 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.7 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 596 kB
website/build/index.html 37.6 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Mar 2, 2022

LGTM 👍 thanks

@slorber slorber merged commit 6cbc589 into main Mar 2, 2022
@slorber slorber deleted the jc/blog-author-email branch March 2, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants