Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): restore docusaurus search meta #6827

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 3, 2022

Motivation

In #6707 we replaced docusaurus_x meta by Algolia meta (biasing toward Algolia)

Unfortunately the former metas were actually used by some third-party search plugins: cmfcmf/docusaurus-search-local#99

To avoid annoying anyone for now I'm duplicating the metadata

In the future I'd like to avoid doing so (as it slightly increase page size uselessly), but we'll figure this later

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 3, 2022
@slorber slorber requested review from lex111 and Josh-Cena as code owners March 3, 2022 14:37
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 3, 2022
@netlify
Copy link

netlify bot commented Mar 3, 2022

✔️ [V2]

🔨 Explore the source changes: 823eb0f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6220d2a9c24d840008a2c82a

😎 Browse the preview: https://deploy-preview-6827--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6827--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Size Change: +310 B (0%)

Total Size: 790 kB

Filename Size Change
website/build/assets/js/main.********.js 596 kB +190 B (0%)
website/build/index.html 38.4 kB +120 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.7 kB
website/build/assets/css/styles.********.css 105 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants