Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): refactor routes generation logic #7054

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Refactored types, added lots of comments because this part is pretty confusing to everyone.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Test & build

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 29, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022

[V2]

Name Link
🔨 Latest commit 339078f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6242bfb81a39040008c9c14e
😎 Deploy Preview https://deploy-preview-7054--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7054--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 807 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 613 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 7766226 into main Mar 29, 2022
@Josh-Cena Josh-Cena deleted the jc/routes-refactor branch March 29, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants