-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme-classic): fix docs sidebar layout shifts when expanding categories #7134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we fix this in Infima instead?
I don't think so, Infima's responsibility is to define the design for collapsible category items, not assume in which kind of container/parent they will be used and what padding should be applied in a given context (the current padding was already defined in Docusaurus btw). |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7134--docusaurus-2.netlify.app/ |
Size Change: +100 B (0%) Total Size: 806 kB
ℹ️ View Unchanged
|
I was mainly pointing to things like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
I don't know, there are other values like |
Seems to be working fine in Chrome, Edge, Firefox. Safari remains the last major desktop browser not supporting this, but they have been implementing a lot of new cool things recently so I'm optimist to see this supported soon |
Motivation
Fix #5254
scrollbar-gutter
property support has significantly increased since last time we checked: https://caniuse.com/mdn-css_properties_scrollbar-gutterEven if support is not perfect, it can already be used as a progressive enhancement thanks to
@supports
mediaqueryHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview layout shifts are fixed in all browsers supporting
scrollbar-gutter
other browsers (Safari) should keep working the same
Other related issue: #7130