Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): do not add microdata item prop to trailing breadcrumb #7179

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Fix #7135

cc @kotryna-k

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested on Rich Results.

image

Last item no longer has id.

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Apr 15, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 15, 2022
@netlify
Copy link

netlify bot commented Apr 15, 2022

[V2]

Name Link
🔨 Latest commit c7a4c8c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62597920091a0000081a9fc6
😎 Deploy Preview https://deploy-preview-7179--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7179--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 799 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 604 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 44966e1 into main Apr 15, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-breadcrumb branch April 15, 2022 14:09
@sh0umik
Copy link

sh0umik commented Apr 23, 2022

@Josh-Cena thank you very much for solving this. This is causing massive warnings in my google search console on almost all the pages. need this merged badly in the upcoming release.

@Josh-Cena
Copy link
Collaborator Author

@sh0umik Really? I've tested both configs in the rich results console; neither warned me anything. Where should I test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generated breadcrumb markup
3 participants