refactor: remove long-deprecated routesLoaded lifecycle #7257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: breaking change
|
Size Change: 0 B Total Size: 802 kB ℹ️ View Unchanged
|
|
Let's wait until next week if we get an answer from op in #3918, and then move on 👍 Note: I'm thinking about adding another lifecycle to replace this one, but with a different API and use-case in mind: the ability for one route to "pick data" from another. The idea would be for example to be able to inject a list of blog post, or a doc, as props to your homepage, and similar use-cases. No API design, just a rough idea. |
Josh-Cena
force-pushed
the
jc/remove-routesloaded
branch
from
1f4899c to
c313363
Compare
Josh-Cena
force-pushed
the
jc/remove-routesloaded
branch
from
c313363 to
197579b
Compare
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7257--docusaurus-2.netlify.app/ |
Josh-Cena
added
the
status: awaiting review
Josh-Cena
removed
the
status: awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #3918. After 1 year and a half, we only had one user complaining, and there's no follow-up. I can only assume that this is going to impact no-one.
#3918 mentioned search plugins as a use-case. We now have many successful search plugins that read the routes data through
postBuild, so I believe there's no valid use-case of this lifecycle anymore.Have you read the Contributing Guidelines on pull requests?
Yes