Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): make canary release page display actual canary version name #7334

Merged
merged 1 commit into from
May 5, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 5, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The canary release page has always been a bit inconvenient to use, because it only displays an example. With this PR, we can try our best to display an actually functional name.

Test Plan

Test links

Deploy preview: https://deploy-preview-7334--docusaurus-2.netlify.app/community/canary/

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label May 5, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 5, 2022 05:27
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 5, 2022
@Josh-Cena Josh-Cena changed the title feat(website): make canary release page display actual canary version… feat(website): make canary release page display actual canary version name May 5, 2022
@netlify
Copy link

netlify bot commented May 5, 2022

[V2]

Name Link
🔨 Latest commit b203803
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627386754c8e0d0008b104b5
😎 Deploy Preview https://deploy-preview-7334--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 5, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 54 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 89 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented May 5, 2022

Size Change: +58 B (0%)

Total Size: 807 kB

Filename Size Change
website/build/assets/js/main.********.js 612 kB +58 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 51.3 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.8 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented May 5, 2022

🤪 that feels a bit convoluted but why not 🤷‍♂️

What I don't like is that it produces a few confusing fouc/shifts on navigating/refresh

(particularly the orange->green admonition flash)

@Josh-Cena
Copy link
Collaborator Author

That's expected, though. I can't see a better way to fix it. Unless you want some cooler animations?

@slorber
Copy link
Collaborator

slorber commented May 5, 2022

🤷‍♂️ that seems ok

we'll see if anyone complains but it's just our website so not a big deal

@slorber slorber merged commit 9207caf into main May 5, 2022
@slorber slorber deleted the jc/canary-page branch May 5, 2022 14:03
@Josh-Cena Josh-Cena added pr: documentation This PR works on the website or other text documents in the repo. and removed pr: documentation This PR works on the website or other text documents in the repo. labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants