-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): make canary release page display actual canary version name #7334
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +58 B (0%) Total Size: 807 kB
ℹ️ View Unchanged
|
🤪 that feels a bit convoluted but why not 🤷♂️ What I don't like is that it produces a few confusing fouc/shifts on navigating/refresh (particularly the orange->green admonition flash) |
That's expected, though. I can't see a better way to fix it. Unless you want some cooler animations? |
🤷♂️ that seems ok we'll see if anyone complains but it's just our website so not a big deal |
Pre-flight checklist
Motivation
The canary release page has always been a bit inconvenient to use, because it only displays an example. With this PR, we can try our best to display an actually functional name.
Test Plan
Test links
Deploy preview: https://deploy-preview-7334--docusaurus-2.netlify.app/community/canary/