Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying custom target for FooterLogo #7557

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

vannyle
Copy link
Contributor

@vannyle vannyle commented Jun 3, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

In the current documentation, it says Customization of the logo object. See Navbar logo for details, but it's not allowed to add a footer logo target.
This issue has been raised before in this PR #2344, it's available to specify a target only for the navbar logo.
It would be great if it works for the footer logo as well.

Test Plan

  • Set the external link for the footer.logo.href property, and set the footer.logo.target property to "_self" - make sure that the external link opens in the current tab. This use case is the main goal of PR.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 3, 2022
@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Jun 3, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, very timely PR 😄

@netlify
Copy link

netlify bot commented Jun 3, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 8770a5e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/629a1d12a9c04e000b3364f5
😎 Deploy Preview https://deploy-preview-7557--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 85 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 99 🟢 100 🟢 100 🟢 90 Report

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 LGTM

@slorber slorber merged commit 5444a23 into facebook:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants