Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): allow any non-boundary characters in Markdown heading ID #7604

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jun 12, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 12, 2022
@Josh-Cena Josh-Cena marked this pull request as ready for review June 12, 2022 04:54
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners June 12, 2022 04:54
@netlify
Copy link

netlify bot commented Jun 12, 2022

[V2]

Name Link
🔨 Latest commit 54edb78
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62ab03c13e1dd366aa1e4dea
😎 Deploy Preview https://deploy-preview-7604--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 12, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 33 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Jun 12, 2022

Size Change: 0 B

Total Size: 801 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.6 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 603 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena changed the title fix(utils): allow any non-boundary characters in Markdown heading id fix(utils): allow any non-boundary characters in Markdown heading ID Jun 15, 2022
@Josh-Cena Josh-Cena force-pushed the jc/fix-heading-id branch from 99aca51 to b2324e5 Compare June 16, 2022 08:09
@Josh-Cena Josh-Cena force-pushed the jc/fix-heading-id branch from b2324e5 to 54edb78 Compare June 16, 2022 08:11
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@slorber slorber merged commit 89e146f into main Jun 16, 2022
@slorber slorber deleted the jc/fix-heading-id branch June 16, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit IDs for markdown headings fail to parse dots
3 participants