-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme): nest theme icons under subfolder @theme/Icon/* #7740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: breaking change
Existing sites may not build successfully in the new version. Description contains more details.
label
Jul 8, 2022
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
approved these changes
Jul 8, 2022
Josh-Cena
changed the title
refactor(theme): Nest theme icons under subfolder @theme/Icon/*
refactor(theme): nest theme icons under subfolder @theme/Icon/*
Jul 8, 2022
Size Change: 0 B Total Size: 804 kB ℹ️ View Unchanged
|
slorber
added a commit
that referenced
this pull request
Jul 14, 2022
K0rdan
added a commit
to Luos-io/luos
that referenced
this pull request
Jul 15, 2022
This was referenced Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: breaking change
Existing sites may not build successfully in the new version. Description contains more details.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
All theme icons have been moved:
@theme/IconXyz
becomes@theme/Icon/Xyz
Pre-flight checklist
Motivation
Continue work of moving theme components into appropriate subfolders => better organization
Test Plan
preview works
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs