Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up ESLint usage #836

Merged
merged 6 commits into from
Jul 7, 2018
Merged

Tidy up ESLint usage #836

merged 6 commits into from
Jul 7, 2018

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Jul 7, 2018

Motivation

  • Use Airbnb ESLint which is stricter and more preferred.
  • Enable ESLint for lib, website, and examples directories.
  • Turn off the errors first.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CircleCI

Related PRs

#815

@yangshun yangshun requested a review from endiliey July 7, 2018 07:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 7, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 7, 2018

Deploy preview for docusaurus-preview ready!

Built with commit 56f2f1c

https://deploy-preview-836--docusaurus-preview.netlify.com

@@ -27,15 +27,14 @@
},
"lint-staged": {
"linters": {
"{lib,examples}/**/*.js": [
"{lib,examples,website}/**/*.js": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding @endiliey

@endiliey endiliey merged commit 128dbfc into facebook:master Jul 7, 2018
@yangshun yangshun deleted the eslint branch July 7, 2018 08:33
This was referenced Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants