-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor + add more tests (Part 1) #847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for docusaurus-preview ready! Built with commit 3ad88a7 |
endiliey
changed the title
Refactor mdToHtml in dev & prod + add test
Refactor server.js & generate.js
Jul 12, 2018
endiliey
changed the title
Refactor server.js & generate.js
Refactor server code & add more tests
Jul 12, 2018
endiliey
changed the title
Refactor server code & add more tests
Refactor + add more tests (Part 1)
Jul 13, 2018
yangshun
approved these changes
Jul 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @endiliey! Tests are great
This was referenced Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
server.js
andgenerate.js
Changes
Refactor duplicate
mdToHtml
function inserver.js
andgenerate.js
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/generate.js#L108-L122
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/server.js#L198-L212
Move out
core/routing.js
toserver/routing.js
because it is more related to Express.js routingRefactor & Add tests for
getLanguage
andgetSubDir
inserver/utils.js
😄Refactor duplicate
isSeparateCss
function inserver.js
andgenerate.js
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/server.js#L118-L128
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/generate.js#L74-L84
Refactor duplicate
insertTableOfContents
function inserver.js
andgenerate.js
tocore/toc.js
& add test for ithttps://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/generate.js#L60-L70
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/server.js#L106-L116
Moved
core/getTOC.js
function tocore/toc.js
so nowcore/toc.js
has two functions:Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
https://deploy-preview-847--docusaurus-preview.netlify.com/