Correct Prism CSS class for code blocks #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 4974d8c |
|
By the way, this does change the appearance of the deploy preview. I'm unsure if it's because the prism theme is now correctly being applied and theming the style blocks, or if there was previous compensation in the lib for this styling change. Previous: Current, in deploy preview:
|
|
This is caused by conflicting theme in highlight.js and prism.js Currently all the syntax in Docusaurus (example: jsx) is working because it uses hljs theme but use prism.js on the syntax highlighting. One solution is to remove the theming on prism.css but correct the prism css class (e.g:language-js)
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CSS class for Prism.js still look to be incorrect - this prevents using existing Prism.js themes out of the box.
See: https://github.com/PrismJS/prism/blob/master/themes/prism-coy.css
Have you read the Contributing Guidelines on pull requests?
Yes - and signed CLA.
Test Plan
No tests required.
Related PRs
#735 #842