Fix Jest tests that fail on Windows #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 2a67560 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the Jest tests that fail on Windows, and suppress the noise that gets emitted from the 'Build files' test suite.
The problem with the failing tests was path separators separators being hard coded to '/'.
The build-tests emit a load of warnings to do with translation, e.g:
These fill up the console and make it difficult to see if the tests are actually passing or not. Given they can just be ignored (they aren't fatal errors, and aren't related to what the tests are checking), I suppressed the console output when the
yarn buildcommand is run within the 'Build files' test suite.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run the Jest tests and make sure they all pass.
I ran the tests on both Windows and Ubuntu and they pass.
Related PRs
N/A