Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add baseUrl to sitemap URLs #902

Merged
merged 1 commit into from
Aug 12, 2018
Merged

Conversation

shaform
Copy link
Contributor

@shaform shaform commented Aug 12, 2018

Motivation

Fix #901. Currently the URLs in sitemap are incorrect when baseUrl != /. This PR fixes the bug.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

It works locally.

When baseUrl = /

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 12, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit fb80d0d

https://deploy-preview-902--docusaurus-preview.netlify.com

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

@endiliey endiliey merged commit 8de57b5 into facebook:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect sitemap URLs when baseURL != /
4 participants