-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Web App Manifest in siteConfig #934
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for docusaurus-preview ready! Built with commit fb8287b |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise approved.
Just need extra opinion from @yangshun @JoelMarcey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for adding this!
I am glad I was able to contribute! Though it was just a small addition :) |
No contribution is too small. Thanks Tirth!
…On Mon, Sep 3, 2018, 12:33 AM Tirth Bodawala ***@***.***> wrote:
I am glad I was able to contribute! Though it was just a small addition :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#934 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQRHQaL5ofNVoTpcbddB9YZt9VyRx7Kks5uXNtjgaJpZM4WUtx0>
.
|
Motivation
To improve user experience and low load time for re-visiting users, I would like to include a service worker to make it a Progressive Web App. Adding service worker is easy with
scripts
in siteConfig but one would require manifest.json to be able to add it to the home screen. With the current code base, there is no extra field to add manifest.json to the head.Thus have added an optional field
manifest
in siteConfig and update thelib/core/Head.js
along withdocs/api-site-config.md
accordingly.Test Plan
Well as the code implies if the config key exists then create the
<link />
tag accordingly. No special test cases are required.