-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polish(theme): MDX images should use async decoding #9470
polish(theme): MDX images should use async decoding #9470
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
👀 |
decoding="async"
to <img />
Tag 🖼
thanks I read on the subject and this seems like a reasonable change Note: this PR took time to merge not because the code was bad, but because you didn't really justify the change and explained the tradeoff. We don't do changes because Next.js use them bindly, we make our own judgement ;) |
Welcome, and I apologize for not providing the correct explanation. |
Unfortunately this change leads to flakiness in our Argos visual tests (#9805) I hope we'll not have to revert it |
no problem, that was worth trying 😄 we'll find a solution |
This pull request adds the
decoding="async"
attribute to the<img />
HTML tag, enhancing image loading performance. This implementation is inspired by the default implementation of the Next.js image component, which prioritizes efficient and fast image loading.