Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-translations): complete and improve Spanish theme translations #9872

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

4troDev
Copy link
Contributor

@4troDev 4troDev commented Feb 20, 2024

I've fixed and updated Spanish translations in theme-common.json at packages/docusaurus-theme-translations/locales/es/. P

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved my working plan.

Updated Spanish Translations in theme-common.json
@facebook-github-bot
Copy link
Contributor

Hi @4troDev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

netlify bot commented Feb 20, 2024

[V2]

Name Link
🔨 Latest commit 11cb077
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65d745b4cf6e530008eba469
😎 Deploy Preview https://deploy-preview-9872--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 20, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 76 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 69 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber changed the title [PR] Updated Spanish Translations in theme-common.json fix(theme-translations): complete and improve Spanish theme translations Feb 20, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 20, 2024
@slorber slorber added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus and removed CLA Signed Signed Facebook CLA labels Feb 20, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 20, 2024
Updated the code to enhance specificity. From `Barra lateral`  to `Barra lateral de Documentos` using `Barra lateral ' can be used for both docs and blogs.
Copy link
Contributor Author

@4troDev 4troDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced Barra lateral with Barra lateral de Documentos for accessibility improvement. However, note that using the "Barra lateral" can work to indicate the sidebar for both docs and blogs.

@4troDev 4troDev requested a review from slorber February 20, 2024 18:57
@slorber
Copy link
Collaborator

slorber commented Feb 21, 2024

Ok thanks

I don't have an expertise in accessibility so we'll see if anyone complains about those changes

Comment on lines 8 to 9
"theme.DocSidebarItem.collapseCategoryAriaLabel": "Colapsar categoría de barra lateral '{label}'",
"theme.DocSidebarItem.expandCategoryAriaLabel": "Ampliar la categoría de la barra lateral '{label}'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not Spanish but that doesn't look good to me. {label} is the name of the category, not the name of the sidebar. Wouldn't it be better to put this placeholder closer to the "categoria" word?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it applies to Spanish, but what we have in French:

  "theme.DocSidebarItem.collapseCategoryAriaLabel": "Réduire la catégorie '{label}' de la barre latérale",
  "theme.DocSidebarItem.expandCategoryAriaLabel": "Développer la catégorie '{label}' de la barre latérale",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{Label} is a place holder if i change it when there is a Label it won't show up since is not in the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm i understand now what you mean it should be “Reducir la categoría '{label}' de la barra lateral”,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants